Page MenuHomePhabricator

Non-existent localisation message ⧼visualeditor-listbutton-undefined-tooltip⧽ appears in a visual diff
Closed, ResolvedPublic

Description

Non-existent localisation message ⧼visualeditor-listbutton-undefined-tooltip⧽ appears in this visual diff: https://pl.wikipedia.org/w/index.php?title=Wikipedia:Kawiarenka/Kwestie_techniczne&diff=prev&oldid=70490190&diffmode=visual&uselang=en

image.png (2×3 px, 988 KB)

The edit re-indents some list items while changing their type.

Event Timeline

Looks like the differ is detecting a DefinitionList changing to a List (numbered or bullet), but our description code can't handle that. Not sure if we should consider definition lists as comparable to bullet/numbered lists or not...

Change 971121 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Visual diff: Describe list type changes

https://gerrit.wikimedia.org/r/971121

Change 971121 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Visual diff: Describe list type changes

https://gerrit.wikimedia.org/r/971121

Change 972466 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (df7099eab)

https://gerrit.wikimedia.org/r/972466

Change 972466 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (df7099eab)

https://gerrit.wikimedia.org/r/972466

matmarex assigned this task to Esanders.